jquery / jquery-ui

Downloads

The official jQuery user interface library. — Read more

This URL has Read+Write access

Autocomplete: Split menu resizing logic into its own method to create a more logical method to proxy for custom sizing.

scottgonzalez (author)

Thu Oct 21 19:15:13 -0700 2010

commit a0c856467d7cb19442ac
tree 727a570997fd6b69706f
parent 6ba75aa698361bf8c87a

Showing 1 changed file with 11 additions and 7 deletions.

ui/jquery.ui.autocomplete.js

18 ••••

ui/jquery.ui.autocomplete.js

View file @ a0c8564

@@ -326,10 +326,8 @@ $.widget( "ui.autocomplete", {
 
   _suggest: function( items ) {
     var ul = this.menu.element
-        .empty()
-        .zIndex( this.element.zIndex() + 1 ),
-      menuWidth,
-      textWidth;
+      .empty()
+      .zIndex( this.element.zIndex() + 1 );
     this._renderMenu( ul, items );
     // TODO refresh should check if the active item is still in the dom, removing the need for a manual deactivate
     this.menu.deactivate();
@@ -338,9 +336,15 @@ $.widget( "ui.autocomplete", {
       of: this.element
     }, this.options.position ));
 
-    menuWidth = ul.width( "" ).outerWidth();
-    textWidth = this.element.outerWidth();
-    ul.outerWidth( Math.max( menuWidth, textWidth ) );
+    this._resizeMenu();
+  },
+
+  _resizeMenu: function() {
+    var ul = this.menu.element;
+    ul.outerWidth( Math.max(
+      ul.width( "" ).outerWidth(),
+      this.element.outerWidth()
+    ) );
   },
 
   _renderMenu: function( ul, items ) {

0 notes on commit `a0c8564` Show line notes below

Please log in to comment.

...	...	@@ -326,10 +326,8 @@ $.widget( "ui.autocomplete", {
326	326
327	327	_suggest: function( items ) {
328	328	var ul = this.menu.element
329		- .empty()
330		- .zIndex( this.element.zIndex() + 1 ),
331		- menuWidth,
332		- textWidth;
	329	+ .empty()
	330	+ .zIndex( this.element.zIndex() + 1 );
333	331	this._renderMenu( ul, items );
334	332	// TODO refresh should check if the active item is still in the dom, removing the need for a manual deactivate
335	333	this.menu.deactivate();
...	...	@@ -338,9 +336,15 @@ $.widget( "ui.autocomplete", {
338	336	of: this.element
339	337	}, this.options.position ));
340	338
341		- menuWidth = ul.width( "" ).outerWidth();
342		- textWidth = this.element.outerWidth();
343		- ul.outerWidth( Math.max( menuWidth, textWidth ) );
	339	+ this._resizeMenu();
	340	+ },
	341	+
	342	+ _resizeMenu: function() {
	343	+ var ul = this.menu.element;
	344	+ ul.outerWidth( Math.max(
	345	+ ul.width( "" ).outerWidth(),
	346	+ this.element.outerWidth()
	347	+ ) );
344	348	},
345	349
346	350	_renderMenu: function( ul, items ) {

jquery / jquery-ui

0 notes on commit `a0c8564` Show line notes below

Your current locale selection: English. Choose another?

Keyboard Shortcuts

Site wide shortcuts

Commit list

Pull request list

Issues

Network Graph

jquery / jquery-ui

0 notes on commit a0c8564 Show line notes below

Your current locale selection: English. Choose another?

Keyboard Shortcuts

Site wide shortcuts

Commit list

Pull request list

Issues

Network Graph

0 notes on commit `a0c8564` Show line notes below