fixes .css() #13956 #1298
fixes .css() #13956 #1298
Conversation
|
Ping! |
| if ( prop === "bottom" ) { | ||
| return elemPosition.top + parseFloat( elStyles.height ) + "px"; | ||
| } else if ( prop === "right" ) { | ||
| return elemPosition.left + parseFloat( elStyles.width ) + "px"; |
There was a problem hiding this comment.
I was able to trim off 11 bytes (gibson042/jquery@b1lly:13956...b1lly_13956), but it's still +33. @mikesherov, can you think of a better way to express parseFloat( getStyles( elem ).height )?
|
Is this still open? am I supposed to pull down gibsons change and resubmit? |
|
@b1lly You shouldn't need to resubmit; just pull my changes and rebase onto master so |
|
@b1lly @gibson042 Well, @dmethvin wanted to compress it further, you can notice some duplication between lines 518 & 520 which might be (probably) compressed if iterating not on an array but on sth like: {
width: [ "left", "right" ],
height: [ "top", "bottom" ]
}Not sure if he found time to dive into that, though. |
|
I didn't but it did seem a bit more compressible per the discussion @mzgol and I had. |
|
It seems this PR is pretty old and stale, closing |
made the changes, reverted the guy, created a branch