Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged] Browser support: Add Yandex.Browser to the list #106

Closed
wants to merge 2 commits into from

Conversation

@markelog
Copy link
Member

markelog commented Jul 10, 2015

No description provided.

markelog added a commit that referenced this pull request Jul 12, 2015
@mgol mgol force-pushed the jquery:jquery-3 branch from 2260fc5 to e133844 Jul 17, 2015
markelog added a commit that referenced this pull request Jul 17, 2015
@mgol
Copy link
Member

mgol commented Jul 17, 2015

This was fixed in 2260fc5, although the commit will be rebased on top of master until jQuery 3.0.0 is released. @markelog did you want to wait until that happens?

@arthurvr what's the strategy you use for other content sites, like https://github.com/jquery/api.jquery.com/?

@markelog
Copy link
Member Author

markelog commented Jul 17, 2015

This was fixed in 2260fc5, although the commit will be rebased on top of master until jQuery 3.0.0 is released.

Yeah, exactly, commit hashes are not the same, because i added Closes ... comment, but they are the same, this pull will autoclose when that commit will be merged to master.

@arthurvr
Copy link
Member

arthurvr commented Jul 22, 2015

@arthurvr what's the strategy you use for other content sites, like https://github.com/jquery/api.jquery.com/?

We just close the PRs when we land them to the v3 branch, if that's where you're asking for.

@mgol
Copy link
Member

mgol commented Jul 22, 2015

When I merge a PR to the jquery-3 branch it gets auto-closed anyway, see e.g. #107. If we didn't want to get them closed, we'd have to be sure to always cherry-pick, even if a commit can be merged because it's already rebased.

Losing reference to the final version of the commit is not very nice, though. :/

@mgol mgol changed the title Browser support: Add Yandex.Browser to the list [Merged] Browser support: Add Yandex.Browser to the list Nov 2, 2015
@mgol mgol force-pushed the jquery:jquery-3 branch from 67fe3c9 to aef5787 Dec 14, 2015
markelog added a commit that referenced this pull request Dec 14, 2015
@mgol mgol force-pushed the jquery:jquery-3 branch from aef5787 to 5e1ca2a Dec 28, 2015
markelog added a commit that referenced this pull request Dec 28, 2015
@mgol mgol force-pushed the jquery:jquery-3 branch from 5e1ca2a to 5223567 Jan 13, 2016
mgol added a commit that referenced this pull request Jan 13, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 15d15bb to 3227dcc Feb 10, 2016
mgol added a commit that referenced this pull request Feb 10, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 3227dcc to 7898809 Mar 9, 2016
mgol added a commit that referenced this pull request Mar 9, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 23a77ea to 3836173 Mar 30, 2016
mgol added a commit that referenced this pull request Mar 30, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 3836173 to 6775961 Mar 30, 2016
mgol added a commit that referenced this pull request Mar 30, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 6775961 to 4bc7a20 Mar 31, 2016
mgol added a commit that referenced this pull request Mar 31, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 4bc7a20 to d0fa6e2 Apr 25, 2016
mgol added a commit that referenced this pull request Apr 25, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 9e43c87 to 1f2d064 May 9, 2016
mgol added a commit that referenced this pull request May 9, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from 1f2d064 to dd3506d May 20, 2016
mgol added a commit that referenced this pull request May 20, 2016
@mgol mgol force-pushed the jquery:jquery-3 branch from dd3506d to bbbf1df May 21, 2016
mgol added a commit that referenced this pull request May 21, 2016
@timmywil timmywil closed this in b66eaba Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.