Selector: Introduce Sizzle.escape #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //} | ||
| if ( numeric ) { | ||
| // Code-point-escape the offending character, preserving any non-escaped prefix | ||
| return ch.slice( 0, -1 ) + "\\" + ch.charCodeAt( ch.length - 1 ).toString( 16 ) + " "; |
There was a problem hiding this comment.
It is necessary to set the escape sequence apart from following hexadecimal characters (e.g., so "a.b" gets escaped as a\2e b instead of a\2eb, which corresponds to "a双"). See https://drafts.csswg.org/cssom/#escape-a-character-as-code-point .
They are now converted to unescaped U+FFFD replacement character. w3c/csswg-drafts@c202863 w3c/csswg-drafts@061ede6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
SemVer minor
Fixes gh-363
Ref jquery/jquery#1761
Deviates from the spec in allowing NULL input, but attempts to justify it.馃槈