Package: Add jQuery as explicit dependency, with min and max range #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.7.0 is our minimum supported version, 3.x.x our maximum. Closes gh-1779
|
|
scottgonzalez
reviewed
Jan 25, 2017
| @@ -50,7 +50,9 @@ | |||
| "scripts": { | |||
| "test": "grunt" | |||
| }, | |||
| "dependencies": {}, | |||
| "dependencies": { | |||
| "jquery": ">= 1.7.0 < 4.0.0" | |||
There was a problem hiding this comment.
I haven't tested locally, but all of the docs for npm and semver show no spaces between the operator and the version, so just to be safe, let's drop the spaces after the operators.
|
All that really matters is that it's represented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
1.7.0 is our minimum supported version, 3.x.x our maximum.
Closes gh-1779
@Bajix this is supposed to replace your PR, making the dependency a version range, and without the whitespace changes. Would that work for you?