Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iframes where possible #213

Open
agcolom opened this issue Jan 9, 2014 · 7 comments
Open

Remove iframes where possible #213

agcolom opened this issue Jan 9, 2014 · 7 comments

Comments

@agcolom
Copy link
Member

@agcolom agcolom commented Jan 9, 2014

Some widgets can now be used standalone and the corresponding iframes can be replaced by inline examples.

@jaspermdegroot
Copy link
Member

@jaspermdegroot jaspermdegroot commented Jan 23, 2014

Work without page:

  • Listview
  • Collapsible
  • Collapsible set
  • Popup
  • Tabs
  • Toolbar
  • Controlgroup
  • Button
  • Checkboxradio
  • Textinput
  • Flipswitch
  • Filterable (as long as the widget you use it with can also work without page)

Don't work without page:

  • Navbar (unless it is inside a toolbar)
  • Selectmenu
  • Slider
  • Rangeslider
  • Table Reflow + Column Toggle
  • Panel (can be outside a page, but you still need a page)
  • Dialog (is a page)

NOTES:

  • You always have to set a theme for widgets that are not on a page!
  • We have to set $.mobile.gradeA=$.noop to prevent JQM taking over the page

@arschmitz @gabrielschulhof - Can you please check if this list is correct?

@agcolom
Copy link
Member Author

@agcolom agcolom commented Jan 23, 2014

Thanks! So I'll start working on this as soon as I get a chance now... Maybe this evening...

@kristoferjoseph
Copy link
Member

@kristoferjoseph kristoferjoseph commented Jan 23, 2014

If you want to search the code for where iframes are used in the documentation you could use something like:
grep -niH iframe entries/*xml

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Jan 23, 2014

... from the root of the API docs repository.

@agcolom
Copy link
Member Author

@agcolom agcolom commented Jan 23, 2014

OK :-) Thanks

@agcolom
Copy link
Member Author

@agcolom agcolom commented Feb 4, 2014

just for the record, here's how this could look:
http://jsbin.com/OcUsokO/3/edit

@agcolom
Copy link
Member Author

@agcolom agcolom commented Feb 11, 2014

Change of plan: we will use populated iframes instead no iframe at all to ensure that the jQuery Mobile CSS doesn't break the api docs style. This means that we need to modify https://github.com/jquery/grunt-jquery-content/blob/master/tasks/jquery-xml/entries2html-base.xsl so that the xsl produces what we need: similar to entry examples, without desc, without code in hte code section that is not in "begin-demo" ... "end-demo" for example, where an example would be:

<div data-role="header">
    <h1>jQuery Mobile Example</h1>
</div>
<div role="main" class="ui-content">
    <!--begin-demo-->
    <div data-role="collapsible">
        <h3>I'm a header</h3>
        <p>I'm the collapsible content. By default I'm closed, but you can click the header to open me.</p>
    </div>
    <!--end-demo-->
</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.