fix typos with misspell #3671
fix typos with misspell #3671
Conversation
This PR is part of a campaign to fix a lot of typos on github! You can see the progress on https://github.com/fixTypos/fix_typos/ https://github.com/client9/misspell
|
@aspala, thanks for your PR! By analyzing the history of the files in this pull request, we identified @markelog, @gibson042 and @jeresig to be potential reviewers. |
Only the "behaviour" spelling correction needs to be done, can you revert the others?
external/qunit/qunit.js
Outdated
| @@ -1172,7 +1172,7 @@ Test.prototype = { | |||
| filter = filter.slice( 1 ); | |||
| } | |||
|
|
|||
| // If the filter matches, we need to honour include | |||
| // If the filter matches, we need to honor include | |||
There was a problem hiding this comment.
anything in /external is an external dependency so you'd need to report it in that project.
external/sinon/sinon.js
Outdated
| @@ -5738,7 +5738,7 @@ if (typeof sinon === "undefined") { | |||
| * Add-on for sinon.fakeServer that automatically handles a fake timer along with | |||
| * the FakeXMLHttpRequest. The direct inspiration for this add-on is jQuery | |||
| * 1.3.x, which does not use xhr object's onreadystatehandler at all - instead, | |||
| * it polls the object for completion with setInterval. Dispite the direct | |||
| * it polls the object for completion with setInterval. Despite the direct | |||
There was a problem hiding this comment.
anything in /external is an external dependency so you'd need to report it in that project.
test/data/jquery-1.9.1.js
Outdated
| @@ -4328,7 +4328,7 @@ setDocument = Sizzle.setDocument = function( node ) { | |||
| assert( function( div ) { | |||
|
|
|||
| // Select is set to empty string on purpose | |||
| // This is to test IE's treatment of not explictly | |||
| // This is to test IE's treatment of not explicitly | |||
There was a problem hiding this comment.
This is inside a previous release of jQuery used internally so we wouldn't want to change it.
test/data/jquery-1.9.1.js
Outdated
| @@ -7036,7 +7036,7 @@ jQuery.extend( { | |||
| value += "px"; | |||
| } | |||
|
|
|||
| // Fixes #8908, it can be done more correctly by specifing setters in cssHooks, | |||
| // Fixes #8908, it can be done more correctly by specifying setters in cssHooks, | |||
There was a problem hiding this comment.
This is inside a previous release of jQuery used internally so we wouldn't want to change it.
| @@ -813,7 +813,7 @@ QUnit.test( "end()", function( assert ) { | |||
|
|
|||
| var x = jQuery( "#yahoo" ); | |||
| x.parent(); | |||
| assert.equal( "Yahoo", jQuery( "#yahoo" ).text(), "check for non-destructive behaviour" ); | |||
| assert.equal( "Yahoo", jQuery( "#yahoo" ).text(), "check for non-destructive behavior" ); | |||
There was a problem hiding this comment.
I'm okay with changing British to US spelling, but not particularly bothered about the original.
| @@ -2279,7 +2279,7 @@ QUnit.test( "Cloned, detached HTML5 elems (#10667,10670)", function( assert ) { | |||
| // First clone | |||
| $clone = $section.clone(); | |||
|
|
|||
| // This branch tests a known behaviour in modern browsers that should never fail. | |||
| // This branch tests a known behavior in modern browsers that should never fail. | |||
There was a problem hiding this comment.
I'm okay with changing British to US spelling, but not particularly bothered about the original.
This reverts commit 2eefe5a.
|
Done, sorry for the inconvenience :) |
|
Are we good here? |
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
Summary
Fix typos
Checklist