Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated event aliases #2286

Closed
markelog opened this issue May 9, 2015 · 5 comments
Closed

Remove deprecated event aliases #2286

markelog opened this issue May 9, 2015 · 5 comments
Labels
Behavior Change Blocker Event
Milestone
3.0.0

Comments

@markelog
Copy link
Member

@markelog markelog commented May 9, 2015

load, unload and error - deprecated since 1.8.

Ref http://bugs.jquery.com/ticket/11733
@markelog markelog added this to the 3.0.0 milestone May 9, 2015
markelog added a commit to markelog/jquery that referenced this issue May 9, 2015
@markelog
Event: remove deprecated event aliases
cc74c66 
Fixes jquerygh-2286
Ref trac-11733
@markelog markelog mentioned this issue May 9, 2015
Closed
@markelog

This comment has been minimized.

Sign in to view
Copy link
Member Author

@markelog markelog commented May 9, 2015

If we decide to do this, we also need a migrate and docs tickets
@dmethvin

This comment has been minimized.

Sign in to view
Copy link
Member

@dmethvin dmethvin commented May 10, 2015

jquery/jquery-migrate#94 takes care of the Migrate part.
markelog added a commit that referenced this issue May 19, 2015
@markelog
Event: remove deprecated event aliases
Loading status checks…
ef30bdf 
(Cherry-picked from 0705be4)
Fixes gh-2286
Closes gh-2287
Ref trac-11733
@markelog markelog closed this in 0705be4 May 19, 2015
@markelog markelog mentioned this issue Nov 16, 2015
Closed
@markelog markelog mentioned this issue Dec 22, 2015
Closed
@sqrthree sqrthree mentioned this issue Feb 20, 2016
Open
@zowers

This comment has been minimized.

Sign in to view
Copy link

@zowers zowers commented May 21, 2016

upgrade guide says

If you need to attach errors by these names, use the .on() method

should be

If you need to attach events by these names, use the .on() method
@mgol

This comment has been minimized.

Sign in to view
Copy link
Member

@mgol mgol commented May 21, 2016

@zowers Thanks for the report, fixed!

If you find more mistakes, please report them at https://github.com/jquery/jquery.com/issues, this issue tracker is for the jQuery library.

The upgrade guide itself is written in Markdown in https://github.com/jquery/jquery.com/blob/master/pages/upgrade-guide/3.0.md.
@davidtgq davidtgq mentioned this issue May 25, 2016
Closed
@gibson042 gibson042 mentioned this issue Jul 4, 2016
Closed
@darwindlrd

This comment has been minimized.

Sign in to view
Copy link

@darwindlrd darwindlrd commented Jul 13, 2016

Now that I use function that allows do the same job?
@TheDruidsKeeper TheDruidsKeeper mentioned this issue Aug 30, 2016
Merged
mythz added a commit to ServiceStack/ServiceStack that referenced this issue Aug 30, 2016
@TheDruidsKeeper @mythz
jQuery 3.x Compatibility (#1054)
Loading status checks…
e01398b 
Changed $(window).unload() to $(window).on("unload", ) for compatibility with jQuery 3.x (they've removed methods deprecated since 1.8): jquery/jquery#2286
riverma added a commit to riverma/learn.jquery.com that referenced this issue Sep 7, 2016
@riverma
Update document-ready.md
87f3497 
$( window ).load(function () {}) deprecated since v1.8. Should use $( window ).on("load", function () {})
jquery/jquery#2286
@riverma riverma mentioned this issue Sep 7, 2016
Open
jdmeer added a commit to jdmeer/jquery.mosaicflow that referenced this issue Jan 5, 2017
@jdmeer
Remove deprecated jQuery event alias which fixes an incompatibility w…
40e9637 
…ith jQuery 3

jquery/jquery#2286
@jdmeer jdmeer mentioned this issue Jan 5, 2017
Merged
sapegin added a commit to sapegin/jquery.mosaicflow that referenced this issue Jan 6, 2017
@jdmeer @sapegin
Remove deprecated jQuery event alias which fixes an incompatibility w…
Loading status checks…
a6e9f8c 
…ith jQuery 3 (#56)

jquery/jquery#2286
@WPprodigy WPprodigy mentioned this issue Dec 8, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Behavior Change Blocker Event
Projects
None yet
Milestone
  3.0.0
6 participants
@markelog @dmethvin @zowers @mgol @darwindlrd @timmywil
You can’t perform that action at this time.