/jquery

New issue

css('animation-iteration-count', 5) doesn't apply style to element #2792

Closed
ufologist opened this Issue Dec 30, 2015 · 2 comments

Assignees

@mgol mgol

Labels

CSS

Projects

None yet

Milestone

  1.12.0/2.2.0

2 participants

@ufologist @mgol
@ufologist
Contributor
ufologist commented Dec 30, 2015

When I use css('animation-iteration-count', 5) I expect element has style="-webkit-animation-iteration-count: 5;" (this vendor prefix is just a example), but it doesn't.

So I debug jQuery.js, I found when I use css('animation-iteration-count', 5) actually become style[ 'WebkitAnimationIterationCount' ] = 5 + 'px'.
Browser consider it a illegal value, because animation-iteration-count only accept infinite | <number>, so this style don't have effect.

This is a reproduceBug demo

So that cssNumber shoud add animationIterationCount property to prevent automatically add "px" to the value.
@ufologist ufologist added a commit to ufologist/jquery that referenced this issue Dec 30, 2015
@ufologist ufologist CSS: Add animation-iteration-count to cssNumber jquery/jquery#2792 1d80ac0
@ufologist ufologist referenced this issue Dec 30, 2015
Closed

CSS: Add animation-iteration-count to cssNumber jquery/jquery#2792 #2793

@ufologist ufologist added a commit to ufologist/jquery that referenced this issue Dec 30, 2015
@ufologist ufologist CSS: Add animation-iteration-count to cssNumber jquery/jquery#2792 48f24c3
@ufologist
Contributor
ufologist commented Dec 31, 2015

Goto #2793 to see how to fix that
@ufologist ufologist closed this Dec 31, 2015
@mgol
Member
mgol commented Dec 31, 2015

Reopening, this shouldn't have been closed.
@mgol mgol reopened this Dec 31, 2015
@ufologist ufologist added a commit to ufologist/jquery that referenced this issue Jan 4, 2016
@ufologist ufologist CSS: Add animation-iteration-count to cssNumber jquery/jquery#2792 4a9b8ce
@mgol mgol added this to the 1.12/2.2 milestone Jan 7, 2016
@mgol mgol added the CSS label Jan 7, 2016
@mgol mgol self-assigned this Jan 7, 2016
@mgol mgol added a commit that closed this issue Jan 7, 2016
@ufologist @mgol ufologist + mgol CSS: Add animation-iteration-count to cssNumber, fix tests 
Fixes gh-2792
Closes gh-2793
 df822ca
@mgol mgol closed this in df822ca Jan 7, 2016
@mgol mgol added a commit that referenced this issue Jan 7, 2016
@ufologist @mgol ufologist + mgol CSS: Add animation-iteration-count to cssNumber, fix tests 
Fixes gh-2792
Closes gh-2793
 b9a6958
@mgol mgol added a commit that referenced this issue Jan 7, 2016
@ufologist @mgol ufologist + mgol CSS: Add animation-iteration-count to cssNumber, fix tests 
(cherry-picked from df822ca)

Fixes gh-2792
Closes gh-2793
 01fb17b
@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016
Open

jQuery #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment