Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Properly detect attachment of Shadow DOM elements #3504
Comments
gibson042
added Bug Needs review
labels
Jan 16, 2017
|
Yes to going forward and investigating, but we may scrap it later depending on how involved this gets. |
timmywil
removed the
Needs review
label
Feb 6, 2017
|
As noted in the meeting, we'd probably benefit from an internal |
timmywil
added this to the
3.2.0
milestone
Feb 13, 2017
timmywil
modified the milestone: 3.3.0, 3.2.0
Mar 6, 2017
gibson042
was assigned
by timmywil
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gibson042 commentedJan 16, 2017
There are a few places where we check document attachment with
jQuery.contains( elem.ownerDocument, elem )(isHiddenWithinTreefor show/hide,curCSSfor inline style fallback,buildFragment/domManip/remove/jQuery.clonefor managing script evaluation during DOM manipulation), all of which fail inside Shadow DOM:We should investigate the cost of a remedy (e.g., a Shadow-DOM-compatible
isAttached( elem )function).