Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomodule attribute is not respected on scripts with sources #4281

Closed
mgol opened this issue Jan 17, 2019 · 1 comment
Closed

nomodule attribute is not respected on scripts with sources #4281

mgol opened this issue Jan 17, 2019 · 1 comment
Assignees
@mgol
Labels
Bug Has Pull Request Manipulation
Milestone
3.4.0

Comments

@mgol
Copy link
Member

@mgol mgol commented Jan 17, 2019

Description

PR #3869 added support for <script type="module"> & some support for the nomodule attribute but with no tests for nomodule and with the attribute only respected on inline scripts.

Ref #3871

Link to test case

http://plnkr.co/edit/rZJmEFJIpPOHDMNJUdxz?p=preview

In modern browsers you should see PASS, instead you'll see FAIL: 2, indicating 2 out of 4 scripts get executed; those are the src-based scripts.
@mgol mgol added this to the 3.4.0 milestone Jan 17, 2019
@mgol mgol self-assigned this Jan 17, 2019
mgol added a commit to mgol/jquery that referenced this issue Jan 17, 2019
@mgol
Manipulation: Respect script nomodule attribute in DOM manipulation
836fe71 
PR jquery#3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.

Fixes jquerygh-4281
Ref jquerygh-3871
Ref jquerygh-3869
@mgol mgol mentioned this issue Jan 17, 2019
Merged
3 of 3 tasks complete
@mgol
Copy link
Member Author

@mgol mgol commented Jan 17, 2019

PR: #4282
@mgol mgol closed this in #4282 Jan 21, 2019
mgol added a commit that referenced this issue Jan 21, 2019
@mgol
Manipulation: Respect script nomodule attribute in DOM manipulation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e4de8b4 
PR #3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.

Fixes gh-4281
Closes gh-4282
Ref gh-3871
Ref gh-3869
@lock lock bot locked as resolved and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Bug Has Pull Request Manipulation
Projects
None yet
Milestone
3.4.0
Linked pull requests

Successfully merging a pull request may close this issue.

Manipulation: Respect script nomodule attribute in DOM manipulation
1 participant
@mgol