Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemeRoller versioning #235

Open
jzaefferer opened this issue Jun 26, 2014 · 0 comments
Open

ThemeRoller versioning #235

jzaefferer opened this issue Jun 26, 2014 · 0 comments

Comments

@jzaefferer
Copy link
Member

@jzaefferer jzaefferer commented Jun 26, 2014

Now that 1.11 is mostly done I'd like to start a discussion about versioning ThemeRoller. This came up while working on the release. Turns out that we forgot to include selectmenu in the TR template. I also had to remove the now unncessary anchors inside the menu markup. For menu it doesn't really matter. Though it means that TR will show selectmenu, even when 1.10 or older is selected. When new releases add more widgets, the difference will become even more apparent.

We already support multiple versions in several places, making everything ever more complicated. I wonder if we can avoid that for TR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.