Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment about "Support: Firefox <=44 only" seems to be wrong #371

Open
camilledalmeras opened this issue Aug 31, 2018 · 0 comments
Open

Comment about "Support: Firefox <=44 only" seems to be wrong #371

camilledalmeras opened this issue Aug 31, 2018 · 0 comments

Comments

@camilledalmeras
Copy link

@camilledalmeras camilledalmeras commented Aug 31, 2018

Hello maintainers,

Pointerup events ceased to be detected on desktop Safari and on Chrome 49 (with more versions probably affected) once I deleted the following code on the faith that I would not be needing it:

    // Support: Firefox <=44 only
    // FF Ubuntu includes the lifted button in the `buttons` property on
    // mouseup.
    // https://bugzilla.mozilla.org/show_bug.cgi?id=1223366
    e.buttons &= ~BUTTON_TO_BUTTONS[e.button];
    if (e.buttons === 0) {
      dispatcher.up(e);
    } else {
      dispatcher.move(e);
    }

I have a hunch this may be the root cause of issue #352.
Crude test case below, with the whole of pep.js as an inline script and the aforementioned snippet commented out.
Thanks.

bug.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.