Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updrag event without move and zero deltas #28
Conversation
given moves=0, dx=0 and dy=0 there will be no move events fired
assigned a default of 3 moves only in the case -move is not a number (null, undefined, etc) or -move=0 and dx=0 and dy=0
|
Thank you for the contribution. As you've probably guessed already, this project isn't well maintained. I've added some details about that here: https://github.com/jquery/jquery-simulate#project-status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I've added this case for the simulation of the drag event:
element.simulate("drag", { moves: 0, dx: 0, dy: 0 });Using Snap SVG I need to simulate in tests a drag without moves. It will be fired only mouseup and mousedown.
Only when dx and dy equal zero I will not assign the default of 3 moves. I have also increased the test of the drag including expectations for the mouseup and mousedown.