Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-BR language file fixed #1900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@leofreitas
Copy link

@leofreitas leofreitas commented Oct 3, 2019

The characters "greater than" and "less than" aren't required and can cause errors.

image

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Oct 3, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@fnagel fnagel self-assigned this Dec 9, 2019
@fnagel
Copy link
Member

@fnagel fnagel commented Dec 10, 2019

@fnagel fnagel changed the title Language file fixed pt-BR language file fixed Dec 11, 2019
@leofreitas
Copy link
Author

@leofreitas leofreitas commented Dec 19, 2019

Hi @fnagel,
This sign ( &#x3C; ) is equal to <. I think this breaks the code because is the beginning of an html tag. If you put this sign in Google Translator, it generates error.

@fnagel
Copy link
Member

@fnagel fnagel commented Jan 2, 2020

@leofreitas The < and > are encoded, so this should never break any markup. Pasting HTML entities into Google Translate is not really a valid use case nor an error. Do you have a real world case where this breaks something?

Anyway, I would like to bring some consistency into the translations.

@arschmitz
Copy link
Member

@arschmitz arschmitz commented Mar 10, 2020

i dont think we should change just this file and i'm not sure the reason for the inconsistency. However unless we can see an example of an actual error caused by this its probably not something to worry about just this second

Base automatically changed from master to main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants