Skip to content

/ cssstyle

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support auto as value for positioning props #123

Open
wants to merge 2 commits into
base: master
from
Open

fix: support auto as value for positioning props #123

wants to merge 2 commits into from

Conversation

@idanen
Copy link

@idanen idanen commented Oct 6, 2020

Fixes #122
idanen added 2 commits Oct 6, 2020
@idanen
fix: support auto as value for positioning props
Loading status checks…
bd4de9e
@idanen
Put closer to similar tests
Loading status checks…
7035224
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 11, 2020 •
edited

Codecov Report

Merging #123 into master will increase coverage by 0.23%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   37.39%   37.62%   +0.23%     
==========================================
  Files          87       87              
  Lines        1182     1188       +6     
  Branches      227      229       +2     
==========================================
+ Hits          442      447       +5     
- Misses        633      634       +1     
  Partials      107      107
Impacted Files Coverage Δ
lib/properties/bottom.js 0.00% <0.00%> (ø)
lib/properties/left.js 0.00% <0.00%> (ø)
lib/properties/right.js 0.00% <0.00%> (ø)
lib/properties/top.js 0.00% <0.00%> (ø)
lib/parsers.js 80.68% <83.33%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b527ed7...7035224. Read the comment docs.
@idanen
Copy link
Author

@idanen idanen commented Nov 1, 2020 •
edited

@tmpvar @jsakas , any chance someone can look into this anytime soon?
@idanen
Copy link
Author

@idanen idanen commented Nov 9, 2020

@domenic maybe?
We really need this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Positioning css properties don't except `auto`
2 participants
@idanen @codecov-io
You can’t perform that action at this time.