Skip to content

/ preact-css-transition-group

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter unrenderable children #15

Open
wants to merge 1 commit into
base: master
from
Open

Filter unrenderable children #15

wants to merge 1 commit into from

Conversation

@DarkoKukovec
Copy link

@DarkoKukovec DarkoKukovec commented Sep 20, 2017

In the current version only null is removed from children, but in order to keep compatibility with React, undefined, true and false should also be removed.
@DarkoKukovec
Filter unrenderable children
Verified
This commit was signed with a verified signature.
DarkoKukovec Darko Kukovec
GPG key ID: 385857B5A07C4E92 Learn about signing commits
Loading status checks…
6341978
@DarkoKukovec
Copy link
Author

@DarkoKukovec DarkoKukovec commented Sep 20, 2017

I see that the tests have failed, but I'm not sure why (I can't reproduce it locally). There is something confusiong going on:

  • CSSTransitionGroup transitionEnter works failed with error AssertionError: expected [ Array(5) ] to have a length of 3 but got 5, but this assertion is not done in this test.
  • CSSTransitionGroup: SVG - not sure if the failed test is related to the change, also in the list of tests, it's marked as passing, but CSSTransitionGroup: NullChildren transitionEnter works is marked as failing

The issues seem to be some kind of race condition in the tests.
Any hints to what's going on and what I can do to fix it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@DarkoKukovec
You can’t perform that action at this time.