Skip to content

Refactor util functions #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamwathan merged 2 commits into from
May 10, 2021
Merged

Refactor util functions #2616

adamwathan merged 2 commits into from
May 10, 2021

Conversation

@20lives
Copy link
Contributor

@20lives 20lives commented Oct 19, 2020

following #2610 this is the first step at removing Lodash

@20lives 20lives changed the title Refactor flattenColorPalette util function Refactor util functions Oct 19, 2020
@adamwathan
Copy link
Member

adamwathan commented Oct 23, 2020 •
edited
Loading

Hey sorry, mind fixing the conflict then happy to merge? Can fix myself if needed. Changed some behavior in getAllConfigs, no longer takes the default second param.

@20lives
Copy link
Contributor Author

20lives commented Oct 23, 2020

😉

@20lives
Copy link
Contributor Author

20lives commented Oct 23, 2020

btw, I also ran additional tests where the experimental features array isn't empty

adamwathan
adamwathan reviewed Oct 23, 2020
View reviewed changes
adamwathan
adamwathan reviewed Oct 25, 2020
View reviewed changes
@20lives 20lives requested a review from adamwathan October 25, 2020 17:01
@20lives
Copy link
Contributor Author

20lives commented Oct 25, 2020

gone

Another conflict, I can't keep up 😂

@20lives 20lives force-pushed the fulodash branch 2 times, most recently from 2fd1572 to aaae694 Compare October 25, 2020 19:26
@codecov-io
Copy link

codecov-io commented Oct 25, 2020 •
edited
Loading

Codecov Report

Merging #2616 (f61752c) into master (86a5a1e) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2616   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         172      172           
  Lines        1727     1727           
  Branches      308      308           
=======================================
  Hits         1606     1606           
- Misses        104      105    +1     
+ Partials       17       16    -1
Impacted Files Coverage Δ
src/util/getAllConfigs.js 75.00% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a5a1e...2dc1f66. Read the comment docs.

@20lives
Copy link
Contributor Author

20lives commented Oct 25, 2020

Dropped flattenColorPalette commit, will add it in another PR.

@adamwathan
Copy link
Member

adamwathan commented Oct 27, 2020

Sorry another conflict 😬

@20lives 20lives force-pushed the fulodash branch 2 times, most recently from 9aac358 to bb1cf46 Compare October 27, 2020 15:51
@adamwathan adamwathan merged commit 77ef260 into tailwindlabs:master May 10, 2021
@adamwathan
Copy link
Member

adamwathan commented May 10, 2021

Finally ;)

@20lives
Copy link
Contributor Author

20lives commented May 10, 2021

Shocking, I can't even remember what I did here.
Was pretty sure this will not be relevant with all the new JIT stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwathan adamwathan Awaiting requested review from adamwathan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@20lives @adamwathan @codecov-io