Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Inline width returns 0 on Android 4 #3602

Closed
Krinkle opened this issue Apr 1, 2017 · 4 comments
Closed

Regression: Inline width returns 0 on Android 4 #3602

Krinkle opened this issue Apr 1, 2017 · 4 comments
Assignees
@timmywil @gibson042
Labels
Dimensions Has Pull Request
Milestone
3.3.0

Comments

@Krinkle
Copy link
Member

@Krinkle Krinkle commented Apr 1, 2017 •
edited

Description

Unit test dimension: width/height on an inline element with no explicitly-set dimensions (gh-3571) has been broken on all Android 4.x versions since it was added in c4598da (gh-3571).

Test case

Before:

screen shot 2017-04-01 at 12 41 21

After:

screen shot 2017-04-01 at 12 39 42

Commits f8faf1489e...c1c549793a
@Krinkle Krinkle mentioned this issue Apr 1, 2017
Closed
@Krinkle Krinkle changed the title dimensions: Inline width broken on Android 4 [jQuery 3 regression] Regression: Inline width returns 0 on Android 4 Apr 1, 2017
@markelog markelog added the Dimensions label Apr 3, 2017
@timmywil
Copy link
Member

@timmywil timmywil commented Apr 3, 2017

You're right about the failure. I'm not sure how the commit you linked is related, unless Android 4 has the opposite issue of Firefox making it so you can't access inline style before computed for some odd reason.
@mgol mgol added this to the 3.3.0 milestone Apr 3, 2017
@mgol
Copy link
Member

@mgol mgol commented Apr 3, 2017

We should fix that before the next release, tagging with 3.3.0.
@Krinkle
Copy link
Member Author

@Krinkle Krinkle commented Apr 3, 2017 •
edited

I'm not sure how the commit you linked is related

Aye, yeah, filtered the git log a bit too much. c4598da (CSS) was in the range but I meant to remove it and keep 473d2ea (Dimensions), instead of the other way around. Added now.
@Krinkle Krinkle mentioned this issue Apr 5, 2017
Closed
@timmywil timmywil self-assigned this Apr 17, 2017
gibson042 added a commit to gibson042/jquery that referenced this issue Jul 27, 2017
@gibson042
Dimensions: Use offsetWidth/offsetHeight for Android inline dimensions
4055130 
Fixes jquerygh-3602
gibson042 added a commit to gibson042/jquery that referenced this issue Jul 27, 2017
@gibson042
Dimensions: Use offsetWidth/offsetHeight for Android inline dimensions
25d1675 
Fixes jquerygh-3602
@gibson042 gibson042 mentioned this issue Jul 27, 2017
Merged
4 of 4 tasks complete
gibson042 added a commit that referenced this issue Jul 31, 2017
@gibson042
Dimensions: Improve offsetWidth/offsetHeight fallback
Loading status checks…
a495784 
Fixes gh-3698
Fixes gh-3602
Closes gh-3738
@Krinkle
Copy link
Member Author

@Krinkle Krinkle commented Jul 31, 2017

Confirmed. This fixed the Dimensions tests for Android 4.

The only exception is Android 4.0, which is consistently failing (timing out) on all jQuery test suites (including Dimensions, but likely unrelated). Most likely something in the setup code of either jQuery or the testrunner is throwing it off.

http://swarm.jquery.org/job/5883

I'll file a separate issue for that.
@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

@gibson042 gibson042

Labels
Dimensions Has Pull Request
Projects
None yet
Milestone
3.3.0
Linked pull requests

Successfully merging a pull request may close this issue.

Dimensions: Improve offsetWidth/offsetHeight fallback
5 participants
@Krinkle @timmywil @markelog @gibson042 @mgol
You can’t perform that action at this time.