Ajax: Deprecate AJAX event aliases, inline event/alias into deprecated #4572
Conversation
mgol
force-pushed the
mgol:deprecated-event-aliases
branch
2 times, most recently
from
7f2efd5
to
45edb67
|
Ready for another review. |
A new `src/deprecated` directory makes it possible to exclude some deprecated APIs from a custom build when their respective "parent" module is excluded without keeping that module outside of the `src/deprecated` directory or the `src/deprecated.js` file.
mgol
changed the title
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 21, 2020
The file contents now lie in deprecated/event.js so the README reference is no longer correct. Ref jquerygh-4572
2 tasks done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
Deprecate AJAX event aliases, inline event/alias.js into deprecated.js.
Regular event aliases are already deprecated, this brings the AJAX ones in line with all the others.
As for inlining - it doesn't make sense to me to have almost all deprecated stuff in
deprecated.jsbut only event aliases inevent/alias.js- but still only imported fromdeprecated.js.If accepted, this should be cherry-picked to
3.x-stableas well.Checklist
New tests have been added to show the fix or feature works