Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #8648

Merged
merged 7 commits into from Jun 14, 2019
Merged

Update .travis.yml #8648

merged 7 commits into from Jun 14, 2019

Conversation

@ecadius
Copy link
Contributor

@ecadius ecadius commented Apr 29, 2019

The builds should run now. refs: #8639 #8618 #8617 #8245

@ecadius
Copy link
Contributor Author

@ecadius ecadius commented May 8, 2019

What has time changed that they don't run anymore? I don't get it. 3 Months ago the build passed: https://travis-ci.com/ecadius/jquery-mobile/builds/99162130

@ecadius ecadius mentioned this pull request May 13, 2019
ecadius added 3 commits Jun 13, 2019
Consistent testing method which is described in the ReadMe.
use ubuntu 16.04
update php version
.travis.yml Outdated

script: npm run-script ci
script: npm run-script test

This comment has been minimized.

@apsdehal

apsdehal Jun 13, 2019
Member

I believe we don't need to change this.

This comment has been minimized.

@ecadius

ecadius Jun 14, 2019
Author Contributor

The ReadMe describes the test process with npm run-script test. What is the purpose of npm run-script ci?

.travis.yml Outdated
@@ -1,21 +1,21 @@
language: php

php:
- "5.5"
- "7.0"

This comment has been minimized.

@apsdehal

apsdehal Jun 13, 2019
Member

IIRC, @arschmitz used to say that there were some issues in upgrading to PHP 7.0.

@apsdehal
Copy link
Member

@apsdehal apsdehal commented Jun 13, 2019

Can you retrigger the build by pushing a commit?

set php version back to 5.5
@ecadius
Copy link
Contributor Author

@ecadius ecadius commented Jun 14, 2019

I reseted the php version back to 5.5. Perhaps the travis tests will pass, but they are a bit random and i simple try to rebuild my local environment which passed all tests.

ecadius added 2 commits Jun 14, 2019
longer timeouts for the tests
@apsdehal
Copy link
Member

@apsdehal apsdehal commented Jun 14, 2019

Only one of the tests' suites is failing, we can figure that one later (has some issue related to phatomjs). Squashing and merging this one for now. Thanks.

@apsdehal apsdehal merged commit 4a6395d into jquery:master Jun 14, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
licence/cla Contributor License Agreement is signed.
Details
@mgol
Copy link
Member

@mgol mgol commented Dec 9, 2019

@apsdehal The issue at https://travis-ci.org/jquery/jquery-mobile/jobs/545864736 is not related to PhantomJS in particular but to the usage of jQuery.isArray which has been removed on jQuery master and will not be in jQuery 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants