Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draggable + sortable offset is wrong #2001

Closed
barisusakli opened this issue Oct 27, 2021 · 6 comments · Fixed by #2009
Closed

draggable + sortable offset is wrong #2001

barisusakli opened this issue Oct 27, 2021 · 6 comments · Fixed by #2009
Labels
Behavior different from 1.12 Bug Comp: Draggable Comp: Sortable Has Pull Request
Milestone
1.13.1

Comments

@barisusakli
Copy link

@barisusakli barisusakli commented Oct 27, 2021

After upgrading from 1.12.1 to 1.13.0 dragging an item to a sortable causes the helper to go out of page when it is over the sortable.

The code to create the draggable is below.

	$('#widgets .available-widgets .widget-panel').draggable({
			helper: 'clone',
			distance: 10,
			connectToSortable: '.widget-area',
		});

Same code works fine on 1.12.1. Feel free to close if this is already reported since I saw some other issues with draggable on 1.13.0
@mgol
Copy link
Member

@mgol mgol commented Oct 28, 2021

Thanks for the report. Can you provide a test case on JS Bin? Thanks!

@mgol mgol added this to the 1.13.1 milestone Oct 28, 2021
@barisusakli
Copy link
Author

@barisusakli barisusakli commented Oct 28, 2021

Hi @mgol here is a jsbin https://jsbin.com/cibumufeni/1/edit?html,css,js,output

This uses 1.12.1 and the drag/drop works. If you change the library included to 1.13.0 it will cause the issue you see in the gif above.

@mgol
Copy link
Member

@mgol mgol commented Oct 29, 2021

Thanks! That confirms it.

@mgol mgol removed the Needs info label Oct 29, 2021
@mgol
Copy link
Member

@mgol mgol commented Nov 7, 2021

I bisected it to c866e45. PR that introduced the regression: #1793.

@mgol mgol mentioned this issue Nov 7, 2021
Closed
mgol added a commit to mgol/jquery-ui that referenced this issue Nov 7, 2021
@mgol @mgol
Sortable: Fix positioning when moving a Draggable item into a Sortable
6de3848 
PR jquerygh-1793 removed setting `this.offset.parent` in the Draggable
`refreshPositions` method which broke position calculations when moving
a Draggable item into a connected Sortable. restore that assignment.

Ref jquerygh-1793
Fixes jquerygh-2001
@mgol mgol mentioned this issue Nov 7, 2021
Merged
@mgol
Copy link
Member

@mgol mgol commented Nov 7, 2021

Fix at #2009: restoring one removal from #1793 fixes the issue.

mgol added a commit to mgol/jquery-ui that referenced this issue Nov 8, 2021
@mgol @mgol
Sortable: Fix positioning when moving a Draggable item into a Sortable
2fb8097 
PR jquerygh-1793 removed setting `this.offset.parent` in the Draggable
`refreshPositions` method which broke position calculations when moving
a Draggable item into a connected Sortable. restore that assignment.

Ref jquerygh-1793
Fixes jquerygh-2001
@mgol mgol closed this in #2009 Nov 15, 2021
mgol added a commit that referenced this issue Nov 15, 2021
@mgol @mgol
Sortable: Fix positioning when moving a Draggable item into a Sortable
b52ee40 
PR gh-1793 removed setting `this.offset.parent` in the Draggable
`refreshPositions` method which broke position calculations when moving
a Draggable item into a connected Sortable. restore that assignment.

Ref gh-1793
Fixes gh-2001
Closes gh-2009
@mgol
Copy link
Member

@mgol mgol commented Jan 20, 2022

jQuery UI 1.13.1 including a fix for this issue has been released: https://blog.jqueryui.com/2022/01/jquery-ui-1-13-1-released/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Behavior different from 1.12 Bug Comp: Draggable Comp: Sortable Has Pull Request
Milestone
1.13.1
Development

Successfully merging a pull request may close this issue.

Sortable: Fix positioning when moving a Draggable item into a Sortable mgol/jquery-ui
2 participants
@mgol @barisusakli