Skip to content

02.1 background #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tommygonzaleza merged 2 commits into from
Mar 23, 2023
Merged

02.1 background #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b8fdb2
instructions now using default value, solution as well
UmiKami Mar 23, 2023
a8e25b6
test now checking for default value repeat
UmiKami Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/02.1-Background/README.es.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Si es una imagen, puedes especificar si quieres que la imagen se repita horizont

4. Construye y previsualiza el ejercicio nuevamente.

5. Cambia el `background-repeat` a `inherit` para que se repita sobre el eje x y el eje y.
5. Cambia el `background-repeat` a `repeat` para que se repita sobre el eje x y el eje y.

6. Construye y previsualiza el ejercicio nuevamente.

Expand Down
2 changes: 1 addition & 1 deletion exercises/02.1-Background/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If it is an image, you can specify if you want the image to be repeated horizont

4. Build and Preview the exercise again.

5. Change the background-repeat to 'inherit' to make it repeat over the x axis and y axis.
5. Change the background-repeat to 'repeat' to make it repeat over the x axis and y axis.

6. Build and Preview the exercise again.

Expand Down
4 changes: 2 additions & 2 deletions exercises/02.1-Background/solution.hide.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
body {
background-image: url(https://4geeksacademy.github.io/exercise-assets/img/bg/small-mosaic.jpg);
background-size: contain;
background-repeat: inherit;
}
background-repeat: repeat;
}
4 changes: 2 additions & 2 deletions exercises/02.1-Background/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ describe("All the styles should be applied", ()=>{
expect(styles["background-size"]).toBe("contain");
});

test("the background-repeat should be 'inherit' without quotes", ()=>{
test("the background-repeat should be 'repeat' without quotes", ()=>{
document.querySelector(
"head"
).innerHTML = `<style>${css.toString()}</style>`;

let styles = window.getComputedStyle(body);
expect(styles["background-repeat"]).toBe("inherit");
expect(styles["background-repeat"]).toBe("repeat");
});

test("You should not change the existing head tag elements", ()=>{
Expand Down