Skip to content

Commit f2ca8f9

Browse files
committed
Menu: Convert tests to new infrastructure
Ref #10119 Ref jquerygh-1528
1 parent a0e3da0 commit f2ca8f9

File tree

7 files changed

+53
-53
lines changed

7 files changed

+53
-53
lines changed

tests/unit/menu/menu.html

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,8 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Menu Test Suite</title>
66

7-
<script src="../../jquery.js"></script>
8-
<link rel="stylesheet" href="../../../external/qunit/qunit.css">
9-
<script src="../../../external/qunit/qunit.js"></script>
10-
<script src="../../../external/jquery-simulate/jquery.simulate.js"></script>
11-
<script src="../testsuite.js"></script>
12-
<script src="../../../external/qunit-assert-classes/qunit-assert-classes.js"></script>
13-
<script>
14-
TestHelpers.loadResources({
15-
css: [ "core", "menu" ],
16-
js: [
17-
"ui/core.js",
18-
"ui/widget.js",
19-
"ui/menu.js"
20-
]
21-
});
22-
</script>
23-
24-
<script src="menu_test_helpers.js"></script>
25-
<script src="menu_common.js"></script>
26-
<script src="menu_core.js"></script>
27-
<script src="menu_events.js"></script>
28-
<script src="menu_methods.js"></script>
29-
<script src="menu_options.js"></script>
30-
31-
<script src="../swarminject.js"></script>
7+
<script src="../../lib/css.js" data-modules="core menu"></script>
8+
<script src="../../lib/bootstrap.js" data-widget="menu"></script>
329
<style>
3310
.ui-menu {
3411
font-size: 15px;

tests/unit/menu/menu_common.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
TestHelpers.commonWidgetTests( "menu", {
1+
define( [
2+
"lib/common",
3+
"ui/menu"
4+
], function( common ) {
5+
6+
common.testWidget( "menu", {
27
defaults: {
38
classes: {},
49
disabled: false,
@@ -20,3 +25,5 @@ TestHelpers.commonWidgetTests( "menu", {
2025
select: null
2126
}
2227
});
28+
29+
} );

tests/unit/menu/menu_core.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./menu_test_helpers",
4+
"ui/menu"
5+
], function( $, menuTestHelpers ) {
26

37
module( "menu: core" );
48

@@ -47,7 +51,7 @@ asyncTest( "#9044: Autofocus issue with dialog opened from menu widget", functio
4751
$( "#test9044" ).focus();
4852
});
4953

50-
TestHelpers.menu.click( element, "3" );
54+
menuTestHelpers.click( element, "3" );
5155
setTimeout( function() {
5256
equal( document.activeElement.id, "test9044", "Focus was swallowed by menu" );
5357
$( "#test9044" ).remove();
@@ -69,4 +73,4 @@ asyncTest( "#9532: Need a way in Menu to keep ui-state-active class on selected
6973
});
7074
});
7175

72-
})( jQuery );
76+
} );

tests/unit/menu/menu_events.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./menu_test_helpers",
4+
"ui/menu"
5+
], function( $, menuTestHelpers ) {
26

3-
var log = TestHelpers.menu.log,
4-
logOutput = TestHelpers.menu.logOutput,
5-
click = TestHelpers.menu.click;
7+
var log = menuTestHelpers.log,
8+
logOutput = menuTestHelpers.logOutput,
9+
click = menuTestHelpers.click;
610

711
module( "menu: events", {
812
setup: function() {
9-
TestHelpers.menu.clearLog();
13+
menuTestHelpers.clearLog();
1014
}
1115
});
1216

@@ -730,4 +734,4 @@ asyncTest( "#10571: When typing in a menu, only menu-items should be focused", f
730734
});
731735
});
732736

733-
})( jQuery );
737+
} );

tests/unit/menu/menu_methods.js

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./menu_test_helpers",
4+
"ui/menu"
5+
], function( $, menuTestHelpers ) {
26

3-
var log = TestHelpers.menu.log,
4-
logOutput = TestHelpers.menu.logOutput,
5-
click = TestHelpers.menu.click;
7+
var log = menuTestHelpers.log,
8+
logOutput = menuTestHelpers.logOutput,
9+
click = menuTestHelpers.click;
610

711
module( "menu: methods", {
812
setup: function() {
9-
TestHelpers.menu.clearLog();
13+
menuTestHelpers.clearLog();
1014
}
1115
});
1216

13-
test( "destroy", function() {
17+
test( "destroy", function( assert ) {
1418
expect( 2 );
15-
domEqual( "#menu2", function() {
19+
assert.domEqual( "#menu2", function() {
1620
$( "#menu2" ).menu().menu( "destroy" );
1721
});
18-
domEqual( "#menu5", function() {
22+
assert.domEqual( "#menu5", function() {
1923
$( "#menu5").menu().menu( "destroy" );
2024
});
2125
});
@@ -109,4 +113,4 @@ test( "widget", function() {
109113

110114
// TODO: test select method
111115

112-
})( jQuery );
116+
} );

tests/unit/menu/menu_options.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./menu_test_helpers",
4+
"ui/menu"
5+
], function( $, menuTestHelpers ) {
26

3-
var log = TestHelpers.menu.log,
4-
logOutput = TestHelpers.menu.logOutput,
5-
click = TestHelpers.menu.click;
7+
var log = menuTestHelpers.log,
8+
logOutput = menuTestHelpers.logOutput,
9+
click = menuTestHelpers.click;
610

711
module( "menu: options", {
812
setup: function() {
9-
TestHelpers.menu.clearLog();
13+
menuTestHelpers.clearLog();
1014
}
1115
});
1216

@@ -118,4 +122,4 @@ test( "{ role: null }", function( assert ) {
118122
});
119123
});
120124

121-
})( jQuery );
125+
} );

tests/unit/menu/menu_test_helpers.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
(function() {
1+
define( function() {
22

33
var lastItem,
44
log = [];
55

6-
TestHelpers.menu = {
6+
return {
77
log: function( message, clear ) {
88
if ( clear ) {
99
log.length = 0;
@@ -30,4 +30,4 @@ TestHelpers.menu = {
3030
}
3131
};
3232

33-
})();
33+
} );

0 commit comments

Comments
 (0)