Convert test infrastructure to AMD #1528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
0f3b6e1 to
315d16b
Compare
|
Reviewed as-is, looks good. I like the renames. |
That's good because the remaining changes are trivial :-) |
|
Just for the record I reviewed all the changes with @scottgonzalez over irc / skype and am +1 on everything. |
* Adds RequireJS and relies on AMD for loading dependencies. * Updates to grunt-contrib-qunit 0.6.0. * Convert `domEqual()` to a proper QUnit assertion. * Introduces two bootstrap files (JS and CSS) which use `data-` attributes to reduce the amount of boilerplate needed in each test
Should eventually replace with qunit-assert-close.
scottgonzalez
added a commit
that referenced
this pull request
Apr 9, 2015
Ref #10119 Ref gh-1528 * Adds RequireJS and relies on AMD for loading dependencies. * Updates to grunt-contrib-qunit 0.6.0. * Convert `domEqual()` to a proper QUnit assertion. * Introduces two bootstrap files (JS and CSS) which use `data-` attributes to reduce the amount of boilerplate needed in each test
scottgonzalez
added a commit
that referenced
this pull request
Apr 9, 2015
Should eventually replace with qunit-assert-close. Ref #10119 Ref gh-1528
scottgonzalez
added a commit
that referenced
this pull request
Apr 9, 2015
scottgonzalez
added a commit
that referenced
this pull request
Apr 9, 2015
scottgonzalez
added a commit
that referenced
this pull request
Apr 9, 2015
Moved QUnit assertion dependencies from `lib/bootstrap` to `lib/qunit`. Corrected bad draggable assertions. Ref gh-1528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1511.
TODO:
tests/.jshintrcEither now or near future:
QUnit.assert.close()with qunit-assert-close moduledomEqual()to its own module