Extended a parser class #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey, @maletsden. Thanks, for PR. |
Owner
|
@maletsden thanks, I'll add now |
Owner
|
@maletsden there're some errors still left. Check this - https://travis-ci.org/AleshaOleg/postcss-sass/jobs/393425991#L1232 |
Author
|
Also, I will write tests for this methods a bit later. Ok? |
Owner
|
@maletsden that's totally fine, but after your last changes tests failing:( |
Author
|
That's most likely because I've changed loop method since It wasn't working properly(it was slicing a part of parameters of loop node) |
Owner
|
@maletsden ok, I'll check later |
This reverts commit a46c970.
…te a 'rule' node instead of 'atrule' and it was SLICING the end of conditional statement
fix eslint errors
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added supporting of @media, @mixin, @include, @extend, loops(@while, @for, @each)