Modified findUniqueFileName() in UploadWorker.kt to use a random 3-di… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…git alphanumeric hash to append to a file name to make it unique. This improves speed over using an incrementing number to append as there are fewer collisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from increment to alphanumeric hash to append to a file name when file name already exists.
Fixes commons-app#2506
This improves speed over using an incrementing number to append as there are fewer collisions. Calls to check if a file name exists are slow so it is best to have as few collisions as possible. I used an alpha-numeric hash as discussed in commons-app#2506, which was voted the best option.
Tests performed (required)
Tested testBetaDebugUnitTest on Pixel 9 Pro XL with API level 35.