Skip to content

Question aboute Minification of CSS #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jogibear9988 opened this issue Nov 7, 2021 · 3 comments
Closed

Question aboute Minification of CSS #89

jogibear9988 opened this issue Nov 7, 2021 · 3 comments
Labels
Milestone

Comments

@jogibear9988
Copy link
Contributor

As I worked on #88 for #85 I found that MinifyStyleFormatter does not combine that attribute.

But with that, I wanted to know, is it intended that MinifyStyleFormater should do this, or should it only write css without beautification?

If so, what's the best way to do it? Should I create a own formater, or is this the wrong place?

@FlorianRappl
Copy link
Contributor

Right now this is only about CSS without beautification. There is, however, no rule that states that the existing implementation cannot be improved / extended.

If your desired output is too specific we can either put the additional behavior behind options or you'd need to create your own formatter.

@FlorianRappl FlorianRappl added question and removed bug labels Nov 7, 2021
jogibear9988 added a commit to jogibear9988/AngleSharp.Css that referenced this issue Nov 7, 2021
@jogibear9988 jogibear9988 mentioned this issue Nov 7, 2021
9 tasks
@jogibear9988
Copy link
Contributor Author

Do you have a good idea where to put the minification?

I've created an example #93
but I'm not sure if that's best way to do. The method could get very huge

@jogibear9988
Copy link
Contributor Author

@FlorianRappl FlorianRappl added this to the v1.0 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants