New request for an overlay to be displayed is not ignored while close animation is running#3
Merged
larister merged 1 commit intoBrandwatchLtd:masterfrom Oct 29, 2015
Conversation
|
@ingdir did you manage to get any QA done on this? |
Author
|
@JonathanSewell This was tested as a part of the New Channel Workflow ticket. Do you think there are any specific scenarios we should be aware of because of this change? |
There was a problem hiding this comment.
Nabd but in future just change this to be multivar declarations.
i.e.
var mask;
var exposed;
etc
There was a problem hiding this comment.
Also I think isClosing is a better name
|
Couple of small style comments but generally lgtm. Merging |
larister
added a commit
that referenced
this pull request
Oct 29, 2015
New request for an overlay to be displayed is not ignored while close animation is running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a new call was made to the plugin and a previous overlay was still being closed with an animation, the new call was ignored. That means if we remove an overlay and immediately try to create a new one, we end up not having an overlay.
Now, if a new call comes while an old closing animation still runs, the animation is completed immediately, final CSS properties set, callbacks called, and new overlay is immediately created.