Initialization

[andrewjknox]

Hi there,
I have multiple sliders on a page (8) and I seem to be having an issue knowing when they're all "fully" initialized.

I've tapped into the event for this, but like you say, sometimes, the animation events can happen after. For me, it seems to always happen when I've got at least one panel inside a slider.

No problem as I'm writing meta data onto the slider html nodes for both sets of events so I know when they've fired for that slider, but sometimes the animation events fire "twice" for each slider when after it is initialized - doesn't happen every time so I can't predict it.

I don't know if you've come across this issue before? I just need to know when all the sliders have settled so I can perform a custom action with them based on the url.

Cheers,
Andrew

[Mottie]

Hi Andrew!

Hmm, the only time I've ever had a problem with callbacks is when I trigger another callback inside... then we get a nice infinite loop of events.

Maybe if you shared a link to the page you're working on or even an example of the issue you're having - modify this demo - it would help. You probably don't need to include all eight sliders.

[andrewjknox]

Hi Rob,
Thanks for the swift response, really appreciated.

I'm struggling to reproduce this but I've noticed if I slow the speed of movement in my code, it's not firing off duplicate completed events.

If I put an extremely quick speed in on that demo (got mine at http://jsfiddle.net/andrewjknox/SJJZB/9/), I can get it to fire one extra completed event. My page is quite asset heavy and I noticed that it only seems to fire extra events in between the last set of completed events and any http requests that go out after them.

That demo of mine has 3 sliders, one of which doesn't have any panels. On a slow speed, it's fires two completed events. On a really quick one, it fires three. I don't need it to be that fast but it did cause the issue I'm having :)

The hunt goes on, I feel this is going to be a late one for me :)

[Mottie]

Hi Andrew!

Ok, I found the problem... I'll include it in the next update. It's going to have a few changes like removing the width and panelWidth options and having those values be set in the css, so once I make sure there aren't any bugs I'll update the plugin.

Thanks for reporting this issue!

[andrewjknox]

Hey Rob,
Phew :) Thank you so much for this looking into this so quickly. I don't suppose you've got a rough idea of when this update will get posted (assuming no bugs!) - trying to work out if I should code around this or carry on with other functionality I need to have ready in a week or two.

Cheers,
Andrew

[Mottie]

Ok sorry for the wait, this should now be fixed in v2.2.2.

[andrewjknox]

Hi Rob,
Just wanted to say cheers for sorting that out so quickly, much appreciated! Not getting duplicate events any more.

I guess the only issue I have is trying to figure out when animation 'and' initialization is complete as sometimes I can't pick up the animation complete event - that only happens some of the time after the slider has raised it initialized event.

[Mottie]

Is there a specific case that you're noticing the animation complete not firing? It would really help if you could provide a demo.

[andrewjknox]

This is only on page load for the record. You mention in the docs that sometimes the completed event can occur after initialization so I assumed that's just something I'll have to deal with and this isn't a bug :) My demo is at http://jsfiddle.net/andrewjknox/SJJZB/20/ - I just do a console.log in the completed event and re-run/refresh the page - sometimes they fire, sometimes they don't but I believe this is as expected.

Animation event always fires once page loads in and I start moving the panels no problem.

For me it seems to be a timing issue - I've brought the speed up to one second and I don't (tried about 100 times testing it!) get any completed events when the page loads in so am fine with that. Just means I can keep track of a total number of sliders on page against total slider initialized events and then I know everythings in place.

[Mottie]

Ok, I finally found the issue and I fixed it in the latest version (v2.2.3), I hope ;)

[andrewjknox]

Absolutely awesome. I'll give that a test drive when I get a chance later on today. I'm definitely putting your excellent slider through some seriously extreme usage :)

[andrewjknox]

You must hate me :)

I seem to have found an issue where the last element in the slider scrolls too far when it's set up for infinite scrolling. As in, you start on the first element and scroll left. The element comes in too far to the right by what looks to be about 50% of it's width. It happens on your demo's too.

Sorry ;)

[Mottie]

Hey!

Naw, I don't hate you for helping me find bugs :P

But, are you sure your browser cache is updated? I just looked at the main demo and everything seems fine.

[Mottie]

Opps, nevermind.. I see what you mean. Fixing it here in a minute.

[andrewjknox]

Hmm, strange - I've flushed cache and still happens (only noticed as it was happening on my dev box on a different machine) - that link in your post above starts off with the top slider at the end panel. If I scroll forward once, then back, that image of the cat isn't central like it was at the start.

[Mottie]

LOL no I forgot to flush my cache :P

Fixed in v2.2.4. Thanks!