Made a jQuery Plugin #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
December 4, 2011 16:40
- Turned the original javascript into a plugin. - Changed the :contains expression to :RD_contains
…ing it from the $input
This reverts commit 05489e6.
- made it so when going down the list would animate the scroll position - now uses the list of items already matched in the variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged your JS into a plugin. I plan to work through some of the code and change a few things, but I haven't had the chance.
I also updated the read me to show how to use the plugin.
In my plugin I used your Modernizr check in the if statement. I wondered if you could change it to
if($searchInput[0].list === null)and get the same result. It worked in Firefox 7.01, Safari 5.1.1 and Chrome 15.0.874.121 on my iMac, but I'm unable to test it on windows/IE.