Skip to content

un-anchored :hover issue #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niallmur wants to merge 17 commits into
base: master
Choose a base branch
from
Open

un-anchored :hover issue #387

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0485042
Add duplicate property-value pairs rule
brettstimmerman Sep 10, 2012
e456ed8
separator changed to "|" and divided Prop from value
stubbornella Sep 10, 2012
ecd91b6
Find duplicate property counts
stubbornella Sep 10, 2012
b5cb040
Add test and rollupwarn for rules-count
stubbornella Sep 10, 2012
fd53a96
instructions for running the dev version
stubbornella Jan 1, 2013
c9ce606
Create non-link-hover
niallmur May 31, 2013
8a72ca4
Create non-link-hover
niallmur May 31, 2013
a8b39b3
Create non-link-hover
niallmur May 31, 2013
e543a32
Update non-link-hover
niallmur Jun 12, 2013
98a6b6f
Update non-link-hover
niallmur Jun 12, 2013
96f1375
Merge branch 'duplicate-property-value-pairs-experimental' of https:/…
niallmur Jun 12, 2013
22745fb
deleted extra non-link-hover file.
niallmur Jun 12, 2013
8e6e033
Added a more complicated test case
niallmur Jun 12, 2013
4da270b
added the .js to file as it was missing
niallmur Jun 12, 2013
f1a88ed
Signed-off-by: niallmur <niallmur@gmail.com>
niallmur Jun 18, 2013
0048664
update
niallmur Jun 18, 2013
151b7fe
Added the ability to deal with an upper case 'A' anchor. Even though …
niallmur Jun 26, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
separator changed to "|" and divided Prop from value
  • Loading branch information
@stubbornella
stubbornella committed Sep 10, 2012
commit e456ed845054f1e665599d88ab5ac375890fe3c9
4 changes: 2 additions & 2 deletions src/rules/duplicate-property-value-pairs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ CSSLint.addRule({
parser.addListener("property", function(event){
var prop = event.property.text.toLowerCase(),
val = event.value.text.toLowerCase(),
key = prop + ':' + val;
key = prop + '|' + val;

if (!count[key]) {
count[key] = 0;
Expand All @@ -44,7 +44,7 @@ CSSLint.addRule({
});

data = data.map(function (item) {
return item[1] + ' => ' + item[0];
return item[1] + '|' + item[0];
}).join('\n');

reporter.rollupWarn('Duplicate property-value-pairs:\n\n' + data);
Expand Down
2 changes: 1 addition & 1 deletion tests/rules/duplicate-property-value-pairs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
var result = CSSLint.verify(".foo { color: #f00; } .bar { color: #f00; }", {"duplicate-property-value-pairs": 1});
Assert.areEqual(1, result.messages.length);
Assert.areEqual("warning", result.messages[0].type);
Assert.areEqual("Duplicate property-value-pairs:\n\n2 => color:#f00", result.messages[0].message);
Assert.areEqual("Duplicate property-value-pairs:\n\n2|color|#f00", result.messages[0].message);
}
}));

Expand Down