Skip to content

Conversation

@gouch
Copy link
Contributor

@gouch gouch commented Apr 22, 2015

This is a valid value that was missing

@tgfjt
Copy link

tgfjt commented Apr 27, 2015

Inserting, It seems should be an alphabetical order:D

@gouch
Copy link
Contributor Author

gouch commented Aug 10, 2015

I'd appreciate this being merged or at least getting some feedback. It's a straightforward bug fix, it passes the tests, and it will resolve issue #590 with CSSLint.

@gamebox
Copy link

gamebox commented Nov 29, 2015

Why was this not merged? The issue is still open and it is mildly annoying.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 9, 2016

@gouch: please fetch, rebase and squash the patches. While at it, use a simple single quote instead of the curly ones.

@frvge
Copy link
Contributor

frvge commented Jan 9, 2016

@gouch Please add it at the location in the right alphabetical order.

@gouch
Copy link
Contributor Author

gouch commented Jan 9, 2016

@XhmikosR Done

@frvge Colors.js is organized like the CSS spec, and I did the same.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 9, 2016

Please squash the commits into one since they refer to the same thing.
On Jan 9, 2016 21:31, "David Gouch" notifications@github.com wrote:

@XhmikosR https://github.com/XhmikosR Done

@frvge https://github.com/frvge Colors.js is organized like the CSS spec
http://www.w3.org/TR/css3-color/#currentcolor, and I did the same.


Reply to this email directly or view it on GitHub
#153 (comment).

@gouch gouch closed this Jan 9, 2016
@gouch gouch reopened this Jan 9, 2016
@gouch
Copy link
Contributor Author

gouch commented Jan 9, 2016

@XhmikosR Should be one commit now

@XhmikosR
Copy link
Member

@gouch: almost there :/ You need to fetch upstream and rebase.

@gouch gouch closed this Jan 14, 2016
@gouch gouch deleted the add-colors branch January 14, 2016 17:18
@gouch
Copy link
Contributor Author

gouch commented Jan 14, 2016

Continued in new pull request: #177
(Couldn't figure out how to "fetch upstream and rebase" while maintaining a single commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants