-
Notifications
You must be signed in to change notification settings - Fork 81
Add manipulation value for the touch-action property. #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nschonni ping on this PR. |
|
@AurelioDeRosa: please fetch, rebase and squash the patches. |
|
The branch is now made of only 1 commit and master can be merged with a fast forward only method. |
|
Thanks! Before merging it I see that there are more possible values from MSDN https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action. Maybe you should add those too? |
|
@stubbornella: can you remove whatever you have added to the repo that forces merging from master? It's annoying and it blocks PRs that don't need any rebase/merging. I'd also remove the master branch CI integration because it doesn't allow one to update the docs without skipping CI. |
|
Updated. |
|
Unfortunately @AurelioDeRosa you need to fetch and rebase because of that repo setting. |
Added missing value for the `touch-action` property. Reference: [1](https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action) [2](https://msdn.microsoft.com/en-gb/library/windows/apps/hh767313.aspx)
|
I've to say that this is a quite cumbersome and tedious process. Especially for small contributions this might really block people from contributing. In jQuery we usually perform these small rebases and tweaks by ourselves, and I think it saves time. |
|
IMO this thing shouldn't exist. It's just useless. That is why I pinged @stubbornella above #154 (comment) I can't change this myself; only repo owners. |
Add manipulation value for the touch-action property.
|
Is this a Github setting do you think? On Sat, Jan 9, 2016 at 5:58 AM, XhmikosR notifications@github.com wrote:
|
|
@stubbornella: yeah, it's in repo settings, branches. Protected branches. |
|
Note that you can leave |
Added
manipulationvalue for thetouch-actionproperty. References: [1] [2]