Skip to content

Conversation

@tophf
Copy link
Contributor

@tophf tophf commented Jul 15, 2015

  • Fix line, col in "enddocument" event.
  • Support @keyframes inside @document blocks.
  • Support nested @document blocks: @document inside @document.
  • Fix @keyframes: consume trailing whitespace after RBRACE
    All other block parsers do it, but _keyframes() didn't, consequently breaking the parser after @keyframes inside @document blocks.

@jawshooah
Copy link
Contributor

Might want to add a testDocumentWithKeyframes (example) to tests/css/Parser.js (and tests/css/CSSParserTests.htm, assuming that's still in use).

@tophf
Copy link
Contributor Author

tophf commented Jul 15, 2015

Added, thank you!

@cscott
Copy link
Contributor

cscott commented Feb 2, 2016

@XhmikosR this patch set can be directly merged as well. LGTM.

@cscott cscott mentioned this pull request Feb 2, 2016
@cscott
Copy link
Contributor

cscott commented Feb 2, 2016

@frvge Perhaps you could review this one? It looks good to me.

@XhmikosR XhmikosR added this to the v0.2.6 milestone Feb 3, 2016
XhmikosR added a commit that referenced this pull request Feb 3, 2016
@XhmikosR XhmikosR merged commit 69bfd59 into CSSLint:master Feb 3, 2016
@tophf tophf deleted the fix-kf-doc branch February 3, 2016 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants