Skip to content

Conversation

@dlockhart
Copy link
Contributor

No description provided.

@frvge
Copy link
Contributor

frvge commented Jan 9, 2016

The appearance property has been dropped as you already stated in your other PR. ( https://wiki.csswg.org/spec/css4-ui#dropped-css3-features ) but work is underway for a new one ( https://drafts.csswg.org/css-ui-4/#propdef-appearance ) It seems like only Firefox has implemented "radio-button" but sources disagree.

There are bigger lists of appearance values. For example https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance . In this one "radio-button" isn't listed.

I think we should add everything we can find, or nothing. Looking for more feedback.

Please also rebase.

@dlockhart
Copy link
Contributor Author

radio-button isn't actually the problem here -- it was already listed as an acceptable value before this change. radio is the value that I added, which is listed in the Mozilla documentation.

@frvge
Copy link
Contributor

frvge commented Jan 11, 2016

Ok, true, but the other point remains. Requesting more feedback from others (@XhmikosR ). Please rebase.

@frvge frvge added the Rebase label Jan 11, 2016
@mattiacci
Copy link
Contributor

Adding the other values seems reasonable, but I see no reason to wait for those additions to merge this.

@frvge
Copy link
Contributor

frvge commented Jan 13, 2016

Ok, we can merge this one then after the rebase. I'll see if I can spend a bit of time next week on going through the various documentations and then trying to make the list as long as possible. Then hopefully we'll cover all.

@XhmikosR
Copy link
Member

I'm baffled with all this because it's not a standard yet. That being said, we should add all of the current properties.

@stubbornella
Copy link
Member

We made a decision some time ago to give preference to how actual browsers behave and CSS devs author over exactly what is standardized. Eg the IE property hacks. Nick wanted to blow up if we saw one, but they were still heavily used at that point. We needed to support the behavior.

On Tue, Jan 12, 2016 at 5:26 PM, Frank van Gemeren
notifications@github.com wrote:

Ok, we can merge this one then after the rebase. I'll see if I can spend a bit of time next week on going through the various documentations and then trying to make the list as long as possible. Then hopefully we'll cover all.

Reply to this email directly or view it on GitHub:
#171 (comment)

@XhmikosR
Copy link
Member

@stubbornella: please remove that annoying rebase thing from the repository's settings.

@nschonni
Copy link
Member

@XhmikosR status check is removed

@XhmikosR
Copy link
Member

@nschonni: thanks!

@XhmikosR XhmikosR removed the Rebase label Jan 15, 2016
@frvge frvge added this to the v0.2.6 milestone Jan 18, 2016
frvge added a commit that referenced this pull request Jan 18, 2016
fixes #170: allowing a value of "radio" for the appearance property
@frvge frvge merged commit 08d0b3c into CSSLint:master Jan 18, 2016
@dlockhart dlockhart deleted the allow-appearance-radio branch January 18, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants