Represent most property validators as strings matching the CSS spec formal syntax #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are global: they are valid for every CSS property.
This allows us to use the "Formal Syntax" from the CSS spec. It also lets us simplify the code by removing the multiProperty and groupProperty methods from Validation.
Merged
Contributor
Author
|
@XhmikosR could you take a look at this & merge it if possible. That would clear the way for me to submit the "de-ant-ify" patches as a PR. (Those were based on these.) |
cscott
added a commit
that referenced
this pull request
Feb 10, 2016
Represent most property validators as strings matching the CSS spec formal syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set continues the work on the
Matcherframework to add a simple parser to createMatcherobjects from strings in the CSS formal syntax. This then lets us represent most validators and properties as formal syntax strings, saving function-based validation for basic data types ("simple" validators) and hard cases.The
Matcherobject grew to the point that I went ahead and factored it out into its own file as the last patch here.