Skip to content

Conversation

@toptalo
Copy link
Contributor

@toptalo toptalo commented Oct 19, 2017

When I was try to find bug for issue CSSLint/csslint#718, I notice that not all valid properties for border-image-repeat are described. So I added space. Also I added tests for border-image-repeat.

They all passed:

'initial' is a valid value for 'border-image-repeat''inherit' is a valid value for 'border-image-repeat''unset' is a valid value for 'border-image-repeat''stretch' is a valid value for 'border-image-repeat''round stretch' is a valid value for 'border-image-repeat''foo' is an invalid value for 'border-image-repeat''round stretch foo' is an invalid value for 'border-image-repeat'

So parser-lib is not under suspicion =)

stubbornella
stubbornella previously approved these changes Oct 31, 2017
Copy link
Member

@stubbornella stubbornella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stubbornella
Copy link
Member

Thanks for adding tests!

Copy link
Contributor

@frvge frvge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frvge frvge merged commit e6fe87e into CSSLint:master Nov 11, 2017
@toptalo
Copy link
Contributor Author

toptalo commented Nov 11, 2017

Thanks!

@toptalo toptalo deleted the feature/border-image-repeat-space branch December 29, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants