Add text-decoration-skip #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frvge
requested changes
Dec 28, 2017
| @@ -435,6 +435,8 @@ var Properties = module.exports = { | |||
| "text-decoration-color" : "<text-decoration-color>", | |||
| "text-decoration-line" : "<text-decoration-line>", | |||
| "text-decoration-style" : "<text-decoration-style>", | |||
| "text-decoration-skip" : "none | [ objects || spaces || ink || edges || box-decoration ]", | |||
There was a problem hiding this comment.
The formal syntax in English differs from the version on the Russian translation.
none | [ objects || [ spaces | [ leading-spaces || trailing-spaces ] ] || edges || box-decoration ]
Can you check which is more up2date?
There was a problem hiding this comment.
Yes. I Update Formal Syntax. Get it in Specification
There was a problem hiding this comment.
Okay, MDN finally confused me =)
There are CSS Text Decoration Module Level 3 [CR] That has formal syntax none | [ objects || spaces || ink || edges || box-decoration ]
And CSS Text Decoration Module Level 4 [ED] with formal syntax none | [ objects || [ spaces | [ leading-spaces || trailing-spaces ] ] || edges || box-decoration ]
I Think, it will be better to to use [CR] formal syntax instead [ED] version
…oration Module Level 3 [CR] [CSS Text Decoration Module Level 3](https://www.w3.org/TR/css-text-decor-3/#text-decoration-skip-property)
frvge
approved these changes
Dec 29, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/ru/docs/Web/CSS/text-decoration-skip
https://caniuse.com/#feat=text-decoration