Skip to content

Add touch-action and -ms-touch-action. #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2013

Conversation

tjvantoll
Copy link
Contributor

touch-action is a specced property; this adds it to the list.

It was implemented in IE10 as -ms-touch-action and unprefixed in IE11.

@nzakas
Copy link
Contributor

nzakas commented Dec 13, 2013

Can you add some tests for this change?

@tjvantoll
Copy link
Contributor Author

Can you add some tests for this change?

I wasn't sure the best way to tackle this as most of the individually listed properties don't have specific tests - and there's nothing unique about touch-action. I gave it a shot though. This commit at least makes sure the value is parsed correctly.

@nzakas
Copy link
Contributor

nzakas commented Dec 16, 2013

Sorry, what I meant was to add a test in the validation suite:
https://github.com/nzakas/parser-lib/blob/master/tests/css/Validation.js

@tjvantoll
Copy link
Contributor Author

Ah ok that makes more sense. I'll switch this up.

@tjvantoll
Copy link
Contributor Author

@nzakas I added the tests and rebased this into a single commit.

nzakas added a commit that referenced this pull request Dec 16, 2013
Add touch-action and -ms-touch-action.
@nzakas nzakas merged commit 4cbd2ec into CSSLint:master Dec 16, 2013
@tjvantoll
Copy link
Contributor Author

Hey @nzakas,

Is there any chance you'd be able to create a new version that incorporates this change?

We have a jQuery UI pull that's blocked by this not being in grunt-contrib-csslint. So actually we unfortunately need new versions of grunt-contrib-csslint, csslint, and parser-lib o_O

@nschonni
Copy link
Member

CSSlint actually uses an NPM fuzzy dependency on parser-lib now (0.10.0), so as long as the bump is in the 0.2.x range it won't require a bump in the other packages
Mistyped on my Blackberry

-----Original Message-----
From: TJ VanToll notifications@github.com
Date: Wed, 18 Dec 2013 09:50:56
To: nzakas/parser-libparser-lib@noreply.github.com
Reply-To: nzakas/parser-lib reply@reply.github.com
Subject: Re: [parser-lib] Add touch-action and -ms-touch-action. (#98)

Hey @nzakas,

Is there any chance you'd be able to create a new version that incorporates this change?

We have a jQuery UI pull that's blocked by this not being in grunt-contrib-csslint. So actually we need unfortunately need new versions of grunt-contrib-csslint, csslint, and parser-lib o_O


Reply to this email directly or view it on GitHub:
#98 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants