CV-112348 Support dynamic public path and RTL fetching #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimulatedGREG
commented
Nov 19, 2019
SimulatedGREG
commented
Nov 19, 2019
SimulatedGREG
commented
Nov 19, 2019
Comment on lines
+337
to
+339
| 'if (fetchRTL) {', | ||
| Template.indent([ | ||
| `fullhref = fullhref.replace(/\\.css/i, '.rtl.css');`, |
There was a problem hiding this comment.
Replace .css extension with .rtl.css if fetchRTL is enabled.
danab
approved these changes
Nov 20, 2019
| @@ -5,7 +5,7 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <title>mini-css-extract-plugin testcase</title> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <link rel="stylesheet" type="text/css" href="/dist/preloaded1.css" /> | |||
| <link rel="stylesheet" type="text/css" href="/dist/preloaded1.client.css" /> | |||
There was a problem hiding this comment.
This gets a mime/type error when testing, but it is the same on master, so I guess that's a potential PR to the main repo.
There was a problem hiding this comment.
Yeah, it has to do with the webpack-dev-server settings. Nothing to worry about though.
| filename: '[name].client.css', | ||
| chunkFilename: '[name].chunk.client.css', | ||
| globalRTLFlag: 'rtlLanguageEnabled', | ||
| // outputPublicPath: '/bundles/css/', |
There was a problem hiding this comment.
Suggested change
| // outputPublicPath: '/bundles/css/', |
There was a problem hiding this comment.
This only pertains to the testing environment. Decided to keep this comment for testing later if things need to be adjusted or if the fork needs to pull in changes from the master origin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This PR implements 2 new options for this plugin.
globalRTLFlagAdds the ability to check a global
windowflag at run-time to determine if a RTL stylesheet should be fetched.outputPublicPathAdds the ability to manually set the request's public path, no longer requiring all requests to match
webpack'soutput.publicPathsetting.