onShow called when modal really shown#12
Merged
CreativeDream merged 1 commit intoCreativeDream:masterfrom Jun 9, 2015
Merged
Conversation
…o DOM elements from your dialog are accessible from your onShow callback
CreativeDream
added a commit
that referenced
this pull request
Jun 9, 2015
onShow called when modal really shown
Owner
|
thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great lib, a pleasure to use it !
A stumbled across a small issue: I need to do some post-processing on some DOM elements in my dialog (ie populate some fields).
I used the onShow, which seems the prefect option for that.
However, it is called at the end of the _modalShow, and at that moment, the new DOM piece is not yet drawn by the browser.
Therefore you can't access your new DOM elements. (you might not notice if your post-processing is slow like for example ajaxing some data)
It therefore makes more sense to call the onShow when the dialog has really finished displaying.
That means in the callback of the fadeIn.