Performance Enhancement: Call toArray with Zero Array Size

DaGeRe · DaGeRe · commit 31b702ca54b2 · 2018-10-10T15:08:16.000+02:00
diff --git a/src/main/java/org/apache/commons/csv/CSVParser.java b/src/main/java/org/apache/commons/csv/CSVParser.java
@@ -620,7 +620,7 @@ CSVRecord nextRecord() throws IOException {
         if (!this.recordList.isEmpty()) {
             this.recordNumber++;
             final String comment = sb == null ? null : sb.toString();
-            result = new CSVRecord(this.recordList.toArray(new String[this.recordList.size()]), this.headerMap, comment,
+            result = new CSVRecord(this.recordList.toArray(new String[0]), this.headerMap, comment,
                     this.recordNumber, startCharPosition);
         }
         return result;

Original file line number	Diff line number	Diff line change
`@@ -620,7 +620,7 @@ CSVRecord nextRecord() throws IOException {`
`620`	`620`	`if (!this.recordList.isEmpty()) {`
`621`	`621`	`this.recordNumber++;`
`622`	`622`	`final String comment = sb == null ? null : sb.toString();`
`623`		`- result = new CSVRecord(this.recordList.toArray(new String[this.recordList.size()]), this.headerMap, comment,`
	`623`	`+ result = new CSVRecord(this.recordList.toArray(new String[0]), this.headerMap, comment,`
`624`	`624`	`this.recordNumber, startCharPosition);`
`625`	`625`	`}`
`626`	`626`	`return result;`