Skip to content

Commit 83cd808

Browse files
committed
[CSV-223] Inconsistency between Javadoc of CSVFormat DEFAULT EXCEL.
Apply modified patch from Samuel Martin. Closes apache#26.
1 parent eede739 commit 83cd808

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/changes/changes.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
<action issue="CSV-219" type="fix" dev="ggregory" due-to="Zhang Hongda">The behavior of quote char using is not similar as Excel does when the first string contains CJK char(s).</action>
4444
<action issue="CSV-172" type="fix" dev="ggregory" due-to="Andrew Pennebaker">Don't quote cells just because they have UTF-8 encoded characters.</action>
4545
<action issue="CSV-220" type="add" dev="ggregory" due-to="Gary Gregory">Add API org.apache.commons.csv.CSVFormat.withSystemRecordSeparator().</action>
46+
<action issue="CSV-223" type="fix" dev="ggregory" due-to="Samuel Martin">Inconsistency between Javadoc of CSVFormat DEFAULT EXCEL.</action>
4647
</release>
4748
<release version="1.5" date="2017-09-03" description="Feature and bug fix release">
4849
<action issue="CSV-203" type="fix" dev="ggregory" due-to="Richard Wheeldon, Kai Paroth">withNullString value is printed without quotes when QuoteMode.ALL is specified; add QuoteMode.ALL_NON_NULL. PR #17.</action>

src/main/java/org/apache/commons/csv/CSVFormat.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,8 @@ public CSVFormat getFormat() {
267267
* <li>{@link #withAllowMissingColumnNames(boolean) withAllowMissingColumnNames(true)}</li>
268268
* </ul>
269269
* <p>
270-
* Note: this is currently like {@link #RFC4180} plus {@link #withAllowMissingColumnNames(boolean)
271-
* withAllowMissingColumnNames(true)}.
270+
* Note: This is currently like {@link #RFC4180} plus {@link #withAllowMissingColumnNames(boolean)
271+
* withAllowMissingColumnNames(true)} and {@link #withIgnoreEmptyLines(boolean) withIgnoreEmptyLines(false)}.
272272
* </p>
273273
*
274274
* @see Predefined#Excel

0 commit comments

Comments
 (0)