capitalize sentence and remove underscore#90
Closed
iscomper wants to merge 1 commit intoDataValues:masterfrom
Closed
capitalize sentence and remove underscore#90iscomper wants to merge 1 commit intoDataValues:masterfrom
iscomper wants to merge 1 commit intoDataValues:masterfrom
Conversation
Member
|
What do you need this for? |
Contributor
|
This is part of https://phabricator.wikimedia.org/T204723, I'm mentoring the developer as part of a hackathon |
Member
|
This library is not a great place for wiki specific code. What about putting it in Wikibase Repo instead? Or perhaps in WB DataModel is it is needed elsewhere as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented StringNormalizer interface to capitalize sentence and remove underscore