Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: superfluous error message in dev mode
  • Loading branch information
TheAlexLichter committed Oct 24, 2018
commit 5013961353b7e28d446d892b697c896dfb2a0520
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Before diving into the individual attributes, here are the default settings of t
```js
{
mode: MODES.webpack,
enabled: ({ isDev, isClient }) => (!isDev && isClient),
enabled: ({ isDev, isClient }) => (!isDev && isClient), // or `false` when in dev/debug mode
paths: [
'components/**/*.vue',
'layouts/**/*.vue',
Expand Down Expand Up @@ -93,11 +93,11 @@ Defines the mode, PurgeCSS should be used in.
#### enabled

* Type: `Boolean` or `Function` (only for webpack mode, will receive the build.extend ctx)
* Default: `({ isDev, isClient }) => (!isDev && isClient)` (Only activates in production mode)
* Default: `({ isDev, isClient }) => (!isDev && isClient)` (only activates in production mode) or `false` in debug/dev mode

Enables/Disables the module

* If false, the module won't be activated at all
* If it evaluates to false, the module won't be activated at all
* If a function is given, it'll be properly evaluated in webpack mode (in postcss mode it'll be handled as true)


Expand Down
2 changes: 1 addition & 1 deletion lib/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function nuxtPurgeCss() {

const defaults = {
mode: MODES.webpack,
enabled: ({ isDev, isClient }) => (!isDev && isClient),
enabled: this.options.debug ? false : ({ isDev, isClient }) => (!isDev && isClient),
paths: [
'components/**/*.vue',
'layouts/**/*.vue',
Expand Down
23 changes: 23 additions & 0 deletions test/fixture/configs/webpack/dev.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
const { resolve } = require('path')

module.exports = {
rootDir: resolve(__dirname, '../../../../'),
srcDir: resolve(__dirname, '../../'),
css: ['~/assets/a.css'],
render: {
resourceHints: false
},
modules: ['@@'],
build: {
quiet: false,
extractCSS: true,
optimization: {
splitChunks: {
name: true
}
},
filenames: {
css: () => '[name].css'
}
}
}
7 changes: 7 additions & 0 deletions test/module.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ describe('nuxt-purgecss', () => {
expect(testCSS).toMatch('.ymca')
})

test('don\'t show webpack error message in dev', async () => {
nuxt = await setupNuxt(require('./fixture/configs/webpack/dev'))

const consolaMessages = log.mock.calls.map(c => c[0].message)
expect(consolaMessages).not.toContain('Webpack mode only works with build.extractCSS set to *true*. Either extract your CSS or use \'postcss\' mode')
})

test('globally disable module', async () => {
nuxt = await setupNuxt(require('./fixture/configs/webpack/disabled'))

Expand Down