chore: add how to customize extractors #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAlexLichter
approved these changes
Aug 9, 2019
Member
TheAlexLichter
left a comment
There was a problem hiding this comment.
It'd be nice to have a "working" example in the docs as well
README.md
Outdated
| ``` | ||
|
|
||
| ### Use custom extractors | ||
| Each extention can be applied just one exractor. |
Member
There was a problem hiding this comment.
Suggested change
| Each extention can be applied just one exractor. | |
| Only one extractor can be applied to each file extention. |
README.md
Outdated
|
|
||
| ### Use custom extractors | ||
| Each extention can be applied just one exractor. | ||
| If you apply a custom extractor to the extentions applied default extractor already, you have to override the default value. |
Member
There was a problem hiding this comment.
Suggested change
| If you apply a custom extractor to the extentions applied default extractor already, you have to override the default value. | |
| If you want to apply a custom extractor to the extensions that the default extractor already covers, you have to override the default extractor. This is only possible with the functional notation. |
README.md
Outdated
| extensions: ['html', 'vue', 'js'] | ||
| }, | ||
| { | ||
| extractor: CustomVueExtractor, // This cannot work, because above extractor is applied to 'vue' already. |
Member
There was a problem hiding this comment.
Suggested change
| extractor: CustomVueExtractor, // This cannot work, because above extractor is applied to 'vue' already. | |
| extractor: CustomVueExtractor, // This will not work, because the above extractor is applied to 'vue' already. |
TheAlexLichter
requested changes
Aug 9, 2019
Member
TheAlexLichter
left a comment
There was a problem hiding this comment.
It'd be nice to have a "working" example in the docs as well
c3cf432 to
d6b6f33
Compare
Contributor
Author
|
@manniL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52
I am not confident in English well, please check it.