Skip to content

Conversation

@bovas85
Copy link
Contributor

@bovas85 bovas85 commented Oct 24, 2018

removed $GIT_PARAMS as not recognised (-e defaults to commit message)
added missing --detectOpenHandles to jest to stop async processes.

@TheAlexLichter
Copy link
Member

Hey @bovas85! 👋

Thanks for the PR.
Any reason you want to use Nuxt 2 instead of the bleeding edge build for testing? I think an advantage would be to recognize early issues with (unreleased) edge builds, that's the reason I used it there.

@bovas85
Copy link
Contributor Author

bovas85 commented Oct 24, 2018

Hey @manniL , I think a nuxt-edge would be more suitable for a dev branch rather than release. I'm using this for a prod site (although it's my choice to) and it'd be more in sync with a stable version.

@TheAlexLichter
Copy link
Member

@bovas85 Ah, I see your point there. But there won't be changes that break the stable nuxt release (as nuxt-edge shouldn't introduce breaking changes and if, I'd add a way to support both versions, current + future). ☺️

@bovas85
Copy link
Contributor Author

bovas85 commented Oct 24, 2018

I understand, that's a fair point. I can close this then (although I'd still make the commitlint change in a separate PR as that's blocking potentially others from contributing?)

@TheAlexLichter
Copy link
Member

I'm looking forward to include the changes through separate PRs 👍

Also, please use yarn 1.10 or higher to avoid unsetting the integration field (if possible, otherwise I can fix that too)

@bovas85
Copy link
Contributor Author

bovas85 commented Oct 24, 2018

I have yarn 1.9.4, where do you see that change?

@TheAlexLichter
Copy link
Member

Look in the Files changed menu of your PR ☺️

image

@bovas85
Copy link
Contributor Author

bovas85 commented Oct 24, 2018

I think that was due to removing edge and then adding nuxt 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants