-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
Description
Split off from #52 where @Messj1 wrote:
BTW: There seems to be a bug 🐛 in the code. The interval get not stopped if someone call ulog.set("log_config", {});
Lines 43 to 44 in 2aa3419
| set: function(name) { | |
| if (name === 'log_config') config.update(this) |
Maybe a destructor callback would do the trick. At the end, watch.browser.js would look something like that:
module.exports = function(ulog, pollingTimeout) {
const intervalId = window.setInterval(watchFnc, pollingTimeout);
return () => {
window.clearInterval(intervalId);
}
}Reactions are currently unavailable