Skip to content

Catch case where location is not available. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArthurianX wants to merge 2 commits into from
Closed

Catch case where location is not available. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869ee53
Fix location not being present in a React Native env.
ArthurianX Nov 8, 2019
19fcb19
Use try catch instead of simple comparison
ArthurianX Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
var log = require('./ulog')

var qs = location.search.substring(1),
args = qs && qs.split('&'),
lvl, dbg, i, m
var qs
try {
qs = location.search.substring(1)
} catch(e) {
qs = '';
}

var args = qs && qs.split('&'),
lvl, dbg, i, m

try {
lvl = localStorage.getItem('log')
Expand Down
41 changes: 30 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ulog.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions ulog.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,15 @@ function nop(){}
module.exports = log


var qs = location.search.substring(1),
args = qs && qs.split('&'),
lvl, dbg, i, m
var qs
try {
qs = location.search.substring(1)
} catch(e) {
qs = '';
}

var args = qs && qs.split('&'),
lvl, dbg, i, m

try {
lvl = localStorage.getItem('log')
Expand Down